Repository navigation
fix: record maker-checker task rejections - #415
Merged
Merged
Conversation
Aman-Mittal
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Rejecting a maker-checker task used the DELETE endpoint, removing the audit entry instead of recording the rejection. This change sends the supported
rejectcommand through the maker-checker POST endpoint so the decision remains in the audit trail.It also replaces the browser-native confirmation and hardcoded reject messages with the standard translated destructive dialog, and adds regression coverage that explicitly proves the DELETE endpoint is never called.
Closes #280
Verification
npm run test:unit— 47 files, 364 tests passednpm test -- --watch=false— 868 tests passednpm run lint:prunenpm run buildnpm run i18n:checknpm run check:iconsnpm run check:test-runnergit diff --checkScreenshots
Not applicable — this changes confirmation behavior and API semantics without changing layout.
Checklist
src/app/api/.src/app/core/adapters/instead of direct browser globals or imperative third-party APIs.