[Fix-17820][Master] Fix task timeout alerts failed

[njnu-seafish]

Purpose of the pull request

close #17820

Brief change log

Add query projectUser logic to avoid NullPointerException

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

[ruanwenjun]

Suggested change

	// A null warningGroupId indicates that the user has explicitly configured a "no-alert" policy.
	if (workflowInstance.getWarningGroupId() == null) {
	return;
	}

Don't add this kind of code, we needn't check at here, the method name is not sendTaskTimeoutAlertIfNeeded

[njnu-seafish]

Don't add this kind of code, we needn't check at here, the method name is not sendTaskTimeoutAlertIfNeeded

If the user chooses not to send alerts, workflowInstance.getWarningGroupId() will be null, which will cause a NullPointerException.

[ruanwenjun]

If the user chooses not to send alerts, can this method be called? We need to filter at the upper layer.
If the sendTaskTimeoutAlert method ultimately doesn't send an alert, that would be highly unusual.

[njnu-seafish]

If the user chooses not to send alerts, can this method be called? We need to filter at the upper layer. If the sendTaskTimeoutAlert method ultimately doesn't send an alert, that would be highly unusual.

OK,will handle in TaskTimeoutLifecycleEventHandler

[ruanwenjun]

Suggested change

	assert projectUser != null;
	if(projectUser == null) {
	throw IlleganArguementException("project user is null");
	}

assert will do nothing if the jvm doesn't enable it.

And I don't think we need to check the project user here, since this shouldn't affect the alert, alert only need to take care about alert plugin, if the project user is null, it only affects the alert content.

[njnu-seafish]

if(projectUser == null) {
throw IlleganArguementException("project user is null");
}

The DS project contains a large number of assert statements—I assumed they were recommended for use.
If we don't check in advance, a NullPointerException (NPE) will occur.

[ruanwenjun]

Only a few historical codes contain assert statements.

The proper fix is to set the property to empty, rather than ignore the alert.

[Zzih96]

It seems the issue of the missing workflow timeout alarm function has not been resolved.

[njnu-seafish]

It seems the issue of the missing workflow timeout alarm function has not been resolved.

In our environment, the issue has already been resolved—both task timeout alerts and workflow timeout alerts were occurring.

NPL exceptions mainly occur in the following two places:
1, projectUser == null
2, workflowInstance.getWarningGroupId() == null

[njnu-seafish]

It seems the issue of the missing workflow timeout alarm function has not been resolved.

Of course, we’d be very happy to see any better solutions you might have!

[Zzih96]

workflowInstance.getWarningGroupId()

What version are you using?

[SbloodyS]

It's better to use ProjectDao instead of directly use ProjectMapper.

[njnu-seafish]

It's better to use ProjectDao instead of directly use ProjectMapper.

ok, it's better

[sonarqubecloud]

Quality Gate failed

Failed conditions
13.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

[ruanwenjun]

Please add IT case, if you cannot add IT case ,please at least raise a new issue to supple IT case.