refactor(api): rename GetURIStringPointer to ResolveRequestURI, reject absolute relativePath - #9043
Merged
Conversation
…ject absolute relativePath url.URL.ResolveReference silently discards the base URL when the reference is absolute or protocol-relative, which would make the request target the wrong host without any error. Validate relativePath up front and document the resolution semantics on the renamed function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetURIStringPointertoResolveRequestURIand added a doc comment explaining its resolution semantics.relativePathmust be a relative reference:url.URL.ResolveReferencesilently discards the base URL when the reference is absolute (scheme://...) or protocol-relative (//host/...), which would send the request to the wrong host with no error. Now this returns aBadInputerror instead.ApiClient.Doand the GitHub plugin'srefreshApiClient.do).Test plan
go build ./helpers/pluginhelper/api/... ./plugins/github/token/...passes🤖 Generated with Claude Code