Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR explores one way to make
ListFilesCachetable scoped. A session level cache is still used, but the cache key is made a "table-scoped" path, for which a new structis defined.
TableReferencecomes fromCreateExternalTablepassed toListingTableFactory::create.Additionally, when a table is dropped, all entries related to a table is dropped by modifying
SessionContext::find_and_deregistermethod.Testing (change on adding
list_files_cache()for cli is included for easier testing).What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?