perf: refactor sum int with specialized implementations for each eval_mode #3054
+759
−274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The current implementation of accumulators for
sum_inthandle all three eval modes, making the code complex to understand and also adds overhead due to matching on eval mode within loops.What changes are included in this PR?
Refactored
sum_int.rsfrom a single accumulator with eval mode branches inside loops into 6 separate accumulator implementations:Single-row accumulators:
Groups accumulators:
Key changes:
How are these changes tested?
Existing tests.
Benchmark results show some improvement for group accumulators but not for row accumulators.