GH-35957: [C++][Compute] Graceful error for decimal binary arithmetic and comparison instead of firing confusing assertion

[zanmato1984]

Rationale for this change

When dispatching binary arithmetic and comparison kernels, we do a special casting ahead for decimal arguments. If one argument is decimal and another is the type not castable (e.g., string) to decimal, an assertion fires. On the other hand, we have a graceful way to error on dispatch failure in the general kernel dispatching path after this special casting:

Function 'greater' has no kernel matching input types (string, double)

We want to unify the error path for decimal.

What changes are included in this PR?

Bypass the decimal casting early and not error out if we see the other argument is not castable to decimal, and let the subsequent general kernel dispatching path to handle the error gracefully.

Are these changes tested?

Test included.

Are there any user-facing changes?

None.

• GitHub Issue: [C++] Confusing error with comparison operators with decimal and unsupported type #35957

[zanmato1984]

cc @pitrou

[pitrou]

LGTM, thank you @zanmato1984

[zanmato1984]

Thank you @pitrou for reviewing. I'm merging now.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit deb73a7.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.