fix: Adding request-id header in case of empty header value in request#12837
Merged
Baoyuantop merged 6 commits intoapache:masterfrom Jan 28, 2026
Merged
fix: Adding request-id header in case of empty header value in request#12837Baoyuantop merged 6 commits intoapache:masterfrom
Baoyuantop merged 6 commits intoapache:masterfrom
Conversation
Contributor
|
Hi @shubhammxv, could you explain in detail why this modification was necessary? What is your specific scenario? |
Contributor
Author
|
Hi @Baoyuantop In all the scenarios, we return Also, the plugin's main functionality is to track the requests, But empty value will not really help track it further. |
Baoyuantop
reviewed
Jan 23, 2026
Baoyuantop
reviewed
Jan 28, 2026
nic-6443
previously approved these changes
Jan 28, 2026
Baoyuantop
reviewed
Jan 28, 2026
nic-6443
approved these changes
Jan 28, 2026
AlinsRan
approved these changes
Jan 28, 2026
Baoyuantop
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist