Repository navigation
Implement AIP-85 YAML importer based on the parser - #74586
Merged
Merged
Conversation
ashb
reviewed
Oct 12, 2026
ashb
reviewed
Oct 12, 2026
kaxil
reviewed
Oct 12, 2026
ashb
reviewed
Oct 12, 2026
uranusjr
added
the
AIP-85: Dag Importer
kaxil
approved these changes
Oct 12, 2026
kaxil
reviewed
Oct 12, 2026
uranusjr
force-pushed
the
yaml-importer
branch
from
October 12, 2026 21:20
4121ddf to
79c433f
Compare
1 task done
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 13, 2026
The AIP-85 YAML importer (apache#74586) stores its Dag source with language "yaml", but the Code tab's Monaco setup only registers the Python, TypeScript, Java and Go grammars, so YAML Dags rendered as plain text. Register Monaco's YAML grammar the same way as the others.
1 task done
pierrejeambrun
added a commit
that referenced
this pull request
Oct 13, 2026
The AIP-85 YAML importer (#74586) stores its Dag source with language "yaml", but the Code tab's Monaco setup only registers the Python, TypeScript, Java and Go grammars, so YAML Dags rendered as plain text. Register Monaco's YAML grammar the same way as the others.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the AIP-85 YAML/JSON DAG importer on top of the parser from #74084. A
.yaml/.ymlfile carrying a$schemamarker is discovered, parsed into the validatedDagDocumentmodel, and built into a realDAGwith operators.This adds the
$fmarker to the shared format surface (models,schema.json, parser tests), not just the importer. It's the explicitFileTemplatehalf of AIP-80's file-vs-string split. Flagging it here since it's broader than the importer itself.Links to AIPs:
uses:(ready-made operator) /run:(code task),with:,needs:, and the$x/$t/$f/$constmarkers.$t/$x). The importer realizes this per operator instance: it restrictstemplate_fieldsto exactly the marked fields and emptiestemplate_ext, so nothing renders or file-loads by inference. A marker on a field the operator doesn't template is a build error.$fis an explicit file read (AIP-80'sFileTemplate);$twrapping$fis a template file (read, then render).run:tasks build the native@task.stub_StubOperator. The importer feeds it a callable whose ordered parameters are the run-argument names, so core serialization emits the handler arg-binding spec the lang-SDK runtime validates against.