Skip to content

Fix Unicode prefix matching in the Dag list - #74552

Open
ehddnr301 wants to merge 2 commits into
apache:mainfrom
ehddnr301:fix-unicode-prefix-search
Open

ehddnr301 wants to merge 2 commits into
apache:mainfrom
ehddnr301:fix-unicode-prefix-search

Conversation

@ehddnr301

@ehddnr301 ehddnr301 commented Oct 11, 2026 •

Copy link
Copy Markdown

Searching the Dag list for 카페 can omit 카페매출집계 on PostgreSQL with libc en_US.utf8 collation. The code-point-derived upper bound does not follow the database's collation order.

Use substring equality for non-ASCII display-name prefixes. ASCII prefixes and other prefix filters retain their existing behavior. Update the API description to document the exception.

Before / After

Searching for 카페 returns no results before the fix and correctly returns 카페매출집계 after the fix.

AS-IS TO-BE
Before: no matching Dags After: matching Dag found

Captured from the local UI using the same synthetic data and PostgreSQL en_US.utf8 collation. The before capture uses the original range matcher; the after capture uses substring equality.

In a warm-cache benchmark with 20,000 synthetic Dags, the sum of median count and list query times increased by approximately 3–5 ms. This avoids database-specific collation handling.

Validation:

  • Core API/Always and common.compat/FAB tests, with and without DB access.
  • PostgreSQL 16 regression and API cases: 9 passed.
  • UI tests: 1,865 passed; SimpleAuth UI: 1 passed.
  • Generated Python API client tests: 360 passed.
  • Pre-commit/manual checks and affected documentation builds passed.

The remaining shared prefix matcher work is tracked separately.

related: #74551


Was generative AI tooling used to co-author this PR?
  • Yes — Codex (GPT-6); Claude assisted with the initial investigation.

Generated-by: Codex (GPT-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Drafted-by: Codex (GPT-6)

@boring-cyborg

boring-cyborg Bot commented Oct 11, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant