Repository navigation
Fix agent HITL review for list, marker and function output types - #74537
Open
FrankYang0529 wants to merge 1 commit into
Open
FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
marked this pull request as ready for review
October 11, 2026 04:49
FrankYang0529
requested review from
Lee-W,
ashb,
gopidesupavan and
kaxil
as code owners
October 11, 2026 04:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
output_typeafter human review #73904 (in apache-airflow-providers-common-ai 0.11.0rc1) madeAgentOperatorconvert an answer approved in HITL review with a pydanticTypeAdapterbuilt fromoutput_type. Following cases can pass in 0.10.0, but not 0.11.0rc1.[Verdict, Other], raisesPydanticSchemaGenerationError, and the task fails.ToolOutput(Verdict), raisesAttributeError, and the task fails.NativeOutput,PromptedOutputandTextOutputfail the same way.TypeAdaptervalidates the approved text as the function's arguments and calls the function a second time.How
rehydrate_pydantic_outputhandles anoutput_typethat is neither a class nor a generic alias by parsing the approved text withjson.loads. If the approved text is not JSON, the helper returns the text unchanged. 0.10.0 gave the same result. Classes and generic aliases such aslist[str]orVerdict | Otherstill go throughTypeAdapter.Was generative AI tooling used to co-author this PR?