Repository navigation
Go SDK: answer the Dag-parsing request from Serve - #74391
Merged
jason810496 merged 6 commits intoOct 7, 2026
Merged
jason810496 merged 6 commits into
jason810496 merged 6 commits into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
The stderr excerpt is unrelated to Go Dag parsing, so this PR leaves it out.
Serve takes a bundle.Bundle again, and the Dag serializer is an optional interface the bundle can implement.
The runtime replies on the request id and exits without waiting for an acknowledgement, as the TS runtime and ADR 0003 do.
The panic becomes the Dag's error, and the stack now reaches the Dag processor log through the default slog logger.
The comments now state the behavior in one or two lines.
jason810496
force-pushed
the
airflow-go-sdk-answer-dag-parse-request
branch
from
October 7, 2026 08:02
52eb151 to
e84f9b3
Compare
jason810496
marked this pull request as ready for review
October 7, 2026 08:02
jason810496
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
October 7, 2026 08:02
jason810496
approved these changes
Oct 7, 2026
Member
|
Pushed a few follow-up commits on top:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Go SDK: Answer the Dag-parsing request from Serve.
Serveanswers aDagFileParseRequestwith oneDagFileParsingResult. The result holds the Dags declared withairflow.Dagthat the bundle registered, in registration order. The result leaves out the Dag of a task handler, because that Dag comes from a Python Dag file that is parsed separately.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.