Repository navigation
Let the HITL review plugin address one loop pass or mapped slot - #74351
Merged
Merged
Conversation
ashb
added this pull request to stack #74339
October 6, 2026 15:06
kaxil
reviewed
Oct 6, 2026
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 7, 2026 13:57
5cdd01f to
83e0a0a
Compare
ashb
removed this pull request from stack #74339
October 7, 2026 15:20
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 7, 2026 15:22
83e0a0a to
2d7e1f5
Compare
ashb
added this pull request to stack #74410
October 7, 2026 15:22
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 7, 2026 15:37
2d7e1f5 to
0c53169
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
2 times, most recently
from
October 8, 2026 13:56
73c0b0f to
b8944de
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 8, 2026 16:06
b8944de to
db74ddf
Compare
kaxil
approved these changes
Oct 8, 2026
ashb
force-pushed
the
task-loops-stack-10
branch
2 times, most recently
from
October 9, 2026 10:32
3f0b2a0 to
e42341a
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 9, 2026 14:03
e42341a to
7dbd1f3
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 9, 2026 16:28
7dbd1f3 to
38fbc47
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 9, 2026 20:34
38fbc47 to
62460d2
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 9, 2026 20:46
62460d2 to
6ba936b
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 9, 2026 22:18
6ba936b to
0b6d3c2
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 10, 2026 07:05
0b6d3c2 to
3d8e2a3
Compare
ashb
marked this pull request as ready for review
October 10, 2026 13:56
ashb
requested review from
Lee-W,
amoghrajesh,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
October 10, 2026 13:56
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 10, 2026 14:48
3d8e2a3 to
d3e9ff0
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 10, 2026 16:18
d3e9ff0 to
4a85521
Compare
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 10, 2026 17:12
4a85521 to
a31e0da
Compare
The plugin located a task instance by (task_id, map_index) and stored its review state as XCom under that address. With loop passes sharing a task id and map index that picks an arbitrary pass, so approving or rejecting could resolve another pass's session and write the human action to it. The plugin endpoints now take region_id and region_index and resolve them by the same live-producer rules as the public API, so an ambiguous selection is rejected instead of guessed. Reading, writing and checking completion all use that exact attempt. The review UI forwards the selected task instance's region coordinates when the host provides them. The plugin also runs on hosts that predate regions, where an unknown region_id would break the request, so a host without task instance context keeps the map-only request shape. A modern host that has not resolved a selection renders no session rather than opening another task's. Tests that re-fetch a task instance to run it need the region too, otherwise they run another pass's row.
ashb
force-pushed
the
task-loops-stack-10
branch
from
October 10, 2026 18:24
a31e0da to
79b33b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin located a task instance by (task_id, map_index) and stored its review
state as XCom under that address. With loop passes sharing a task id and map
index that picks an arbitrary pass, so approving or rejecting could resolve
another pass's session and write the human action to it.
The plugin endpoints now take region_id and region_index and resolve them by
the same live-producer rules as the public API, so an ambiguous selection is
rejected instead of guessed. Reading, writing and checking completion all use
that exact attempt. The review UI forwards the selected task instance's region
coordinates when the host provides them. The plugin also runs on hosts that
predate regions, where an unknown region_id would break the request, so a host
without task instance context keeps the map-only request shape. A modern host
that has not resolved a selection renders no session rather than opening another
task's.
Tests that re-fetch a task instance to run it need the region too, otherwise
they run another pass's row.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.