Repository navigation
Check stub tasks against their task handlers - #74067
Draft
jason810496 wants to merge 2 commits into
Draft
jason810496 wants to merge 2 commits into
jason810496 wants to merge 2 commits into
Conversation
jason810496
added this pull request to stack #73978
October 2, 2026 05:49
This was referenced Oct 2, 2026
jason810496
force-pushed
the
jason/core-taskhandler-refactor/13-stub-task-checks
branch
from
October 2, 2026 11:36
f8d8146 to
6fb1dd2
Compare
jason810496
force-pushed
the
jason/core-taskhandler-refactor/13-stub-task-checks
branch
from
October 2, 2026 14:57
6fb1dd2 to
cd7fae0
Compare
jason810496
force-pushed
the
jason/core-taskhandler-refactor/13-stub-task-checks
branch
from
October 3, 2026 07:50
cd7fae0 to
a857663
Compare
This was referenced Oct 3, 2026
The Dag processor will check each stub task against the task handlers of one artifact, the one its coordinator would run for the stub task's Dag, so that a missing handler or an argument the handler cannot take fails the Dag file's import instead of the task on a worker. The argument rules mirror how the Go and Java runtimes bind arguments, defaulted ones included, so the check fails only what would fail at run time and only warns where the runtime still runs the task. The checks are pure functions of the parsed Dags and one probe answer, so every rule is tested with a table and the wiring into the parse can follow on its own.
ADR-0011 still required a Dag's stub task ids to match its handler ids exactly, compared parameter names in order, and unioned the declarations across coordinators. One artifact registers handlers for many Dag files, so a handler with no stub task is expected, and a stub task only runs on the coordinator its queue routes to. ADR-0011 now checks each stub task against the one answer for its coordinator and Dag, and states the binding, defaulted-argument, argless, mapped and schema rules; ADR-0012 points to it.
jason810496
force-pushed
the
jason/core-taskhandler-refactor/13-stub-task-checks
branch
from
October 5, 2026 18:12
a857663 to
893fffa
Compare
jason810496
removed this pull request from stack #73978
October 6, 2026 02:27
jason810496
changed the base branch from
jason/core-taskhandler-refactor/12-zip-dag-discovery
to
jason/core-taskhandler-refactor/07-ts-sdk-task-handler-parse
October 6, 2026 02:30
jason810496
added this pull request to stack #74318
October 6, 2026 02:35
1 task done
jason810496
force-pushed
the
jason/core-taskhandler-refactor/13-stub-task-checks
branch
from
October 6, 2026 02:44
893fffa to
c72868e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (bottom to top), on native #74037 (stack #74170): #73973, #73974, #73975, #74317, #73976, #74067, #74135, #74140, #74141, #73971, #74030, #74031, #74032, #74136, #74137, #74138, #74139
Adds the checks that compare a Dag's stub tasks with the task handlers a probe reports, so a missing handler or an argument a handler cannot take fails the Dag file's import instead of the task on a worker. They are pure functions, and nothing calls them yet: #74135 does.
positionalnamedparams=None, or a mapped stub tasknamed, a param takes the argument of its exact name, else, unlessexact_nameis set, the one whose name folds to its own (lower case,_removed). A folded name two arguments share matches neither.integeraccepted bynumber. Soint | strbinds to an integer param andint | Nonedoes not.$ref,format, ranges and nested items are not compared.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines