Repository navigation
Fix provider.yaml doc URL check with several suspended providers - #73782
Merged
potiuk merged 1 commit intoSep 27, 2026
Merged
Conversation
rjgoyln
marked this pull request as ready for review
September 27, 2026 11:26
rjgoyln
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
September 27, 2026 11:26
potiuk
approved these changes
Sep 27, 2026
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Nice catch ! We never had 2 suspended providers :)
potiuk
force-pushed
the
fix/suspended-provider-doc-url-filter
branch
from
September 27, 2026 12:37
f2a2c6b to
ba38531
Compare
1 task done
Contributor
|
CI failed |
Both suspended-provider filters in the check cross-multiply their inputs, so an entry survives whenever it fails to match any single suspended provider. The check has only ever run with zero or one suspended provider, where that reading is accidentally correct, so suspending a second one would fail the check on the suspended providers' own documentation and report unrelated errors once per suspended provider.
potiuk
force-pushed
the
fix/suspended-provider-doc-url-filter
branch
from
September 27, 2026 18:37
ba38531 to
40d6454
Compare
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 23c6e77 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #73204.
Summary
Both suspended-provider filters in the
provider.yamlcheck are nested-forcomprehensions, so they keep an entry when any suspended provider fails to match it rather than when none do. Suspend two providers at once and each one's doc URLs survive, because the other suspended provider is absent from them — the check then reports them as missing fromprovider.yamland fails on docs it was meant to ignore.The error filter has the same shape, and additionally repeats every unrelated error once per suspended provider.
The cross product is accidentally correct for a single suspended provider, the only configuration the check has ever run with. With none suspended it emptied the set instead — what the two guards were covering for.
Change
scripts/in_container/provider_suspension.pyso they can be tested.The filters moved because the check script refuses to be imported as a module; behaviour for a single suspended provider is unchanged.
Compatibility
Matching stays substring-based: suspending
apache-airflow-providers-gitwould also strip theapache-airflow-providers-githubdocs, as it does today. Narrowing it to the/docs/<package-name>/prefix is a separate change.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines