Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/jobs/scheduler_job_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -3094,7 +3094,7 @@ def _verify_integrity_if_dag_changed(self, dag_run: DagRun, session: Session) ->
.where(
TI.dag_id == dag_run.dag_id,
TI.run_id == dag_run.run_id,
TI.state.in_(State.unfinished),
or_(TI.state.is_(None), TI.state.in_(State.unfinished)),
)
.values(dag_version_id=latest_dag_version.id),
execution_options={"synchronize_session": False},
Expand Down
49 changes: 49 additions & 0 deletions airflow-core/tests/unit/jobs/test_scheduler_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -5204,6 +5204,55 @@ def test_verify_integrity_if_dag_changed(self, dag_maker):
session.rollback()
session.close()

def test_verify_integrity_if_dag_changed_moves_unscheduled_tis(self, dag_maker, session):
"""Task instances that have not been scheduled yet must also be moved to the new Dag version."""
with dag_maker(dag_id="test_verify_integrity_unscheduled_tis", serialized=False) as dag:
BashOperator(task_id="upstream", bash_command="echo hi") >> BashOperator(
task_id="downstream", bash_command="echo hi"
)

orm_dag = dag_maker.dag_model
SerializedDagModel.write_dag(
LazyDeserializedDAG.from_dag(dag), bundle_name="testing", session=session
)
session.commit()
assert orm_dag.bundle_version is None

self.job_runner = SchedulerJobRunner(job=Job())
self.job_runner._create_dag_runs([orm_dag], session)
dr = DagRun.find(dag_id=dag.dag_id, session=session)[0]

self.job_runner._schedule_dag_run(dag_run=dr, session=session)
session.commit()
dag_version_1 = DagVersion.get_latest_version(dr.dag_id, session=session)

states = {ti.task_id: ti.state for ti in dr.task_instances}
assert states == {"upstream": State.SCHEDULED, "downstream": None}

BashOperator(task_id="extra", dag=dag, bash_command="echo hi")
SerializedDagModel.write_dag(
LazyDeserializedDAG.from_dag(dag), bundle_name="testing", session=session
)
session.commit()
dag_version_2 = DagVersion.get_latest_version(dr.dag_id, session=session)
assert dag_version_2.id != dag_version_1.id

self.job_runner._schedule_dag_run(dr, session)
session.commit()

versions = dict(
session.execute(
select(TaskInstance.task_id, TaskInstance.dag_version_id).where(
TaskInstance.dag_id == dr.dag_id, TaskInstance.run_id == dr.run_id
)
).all()
)
assert versions == {
"upstream": dag_version_2.id,
"downstream": dag_version_2.id,
"extra": dag_version_2.id,
}

def test_verify_integrity_not_called_for_versioned_bundles(self, dag_maker, session):
with dag_maker("test_verify_integrity_if_dag_not_changed") as dag:
BashOperator(task_id="dummy", bash_command="echo hi")
Expand Down