Repository navigation
Conversation
40d611b to
1cbf29e
Compare
03f53e2 to
1ea65b6
Compare
8ac5c84 to
19a6c5c
Compare
19a6c5c to
f49f4ce
Compare
f49f4ce to
412bc8e
Compare
potiuk
left a comment
There was a problem hiding this comment.
Updated the labels to make sure all tests and all versions of python are run. However there is one more important change needed - if you look at past changes to docker base image we supported both - previous and new verison of theb base debian - for until next minor version (see the changelog) - this should be done similarly
3d16f9b to
09f1b11
Compare
Keeping Bookworm selectable gives custom image users a transition period while Trixie becomes the default. The expanded all-version lowest-dependencies CI also needs dependency floors that resolve to installable wheels on supported Python versions.
09f1b11 to
b61871f
Compare
|
Thanks @potiuk. I updated the PR to follow the same transition pattern used in the earlier Debian base-image migrations. Trixie is still the default for newly built CI and production images, but Bookworm remains explicitly selectable for custom image builds during the Airflow 3.4.x line. I also updated the Docker image changelog to call this out and to make clear that Bookworm-based custom image build support is expected to be removed in Airflow 3.5.0. |
|
Thank you for this — and I want to be clear up front that closing it is not a judgement on the work. I went through it properly before deciding, and it does what I asked for in my last review: the dual-base transition follows the shape of the previous Debian migrations, Why I'm closing it anywayThe base-image story has moved underneath this PR. We are switching the CI and PROD images to Docker Hardened Images first, and only then revisiting the Debian release. That work is in #73038, with the background in #59625. That changes the ground this PR is standing on. Once the images are based on a hardened Python image, we no longer compile CPython on top of Doing hardened first and Debian second is the order that costs the least total work — but it does mean this PR would be largely redone rather than rebased, which is not a fair thing to ask of you. What is worth keeping, and is independent of all of the aboveSeveral pieces here are not coupled to the base-image question at all and are useful on their own. If you would like to carry any of them forward as separate, much smaller PRs, they would be very welcome:
Sorry to close a PR you have already revised once in response to my review. If you would like to pick the Debian work back up after the hardened images land, please do — and feel free to follow #73038 to see when that is. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Switch official Airflow Docker images from Debian Bookworm to Debian Trixie.
closes: #71494
Why
What Changed
Updated the default Docker base image:
debian:bookworm-slim->debian:trixie-slimUpdated build tooling and CI defaults:
Updated Debian package mappings for Trixie:
libldap-2.5-0->libldap2libssl3->libssl3t64lzma-devis kept only for Bookworm buildslcovinstallation until after Airflow’s custom Python buildMade system-Python detection version-independent:
libpython*packageUpdated MariaDB client installation:
11.810.11mariadb-client-compatwhere needed for MariaDB 11.xUpdated MSSQL client installation:
msodbcsql18installation working with the Trixie baseFixed CI SSH startup logic:
Updated Java example/e2e images:
openjdk-17-jre-headlessUpdated Amazon provider optional
python3-samldependency floor:xmlsec>=1.3.14->xmlsec>=1.3.16xmlsec 1.3.14, and that version fails to build from source with Debian Trixie’s GCC 14Updated IBM DB2 provider dependency floor:
ibm-db>=3.2.0->ibm-db>=3.2.8ibm-db 3.2.0, which fails to build from source on newer Python/Trixie CI imagesUpdated documentation:
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines