Repository navigation
Java SDK: Serialize coordinator client send/receive for thread safety - #69080
Merged
jason810496 merged 2 commits intoJul 1, 2026
Merged
Conversation
FrankYang0529
marked this pull request as ready for review
June 27, 2026 09:43
FrankYang0529
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
potiuk and
uranusjr
as code owners
June 27, 2026 09:43
uranusjr
reviewed
Jun 28, 2026
uranusjr
reviewed
Jun 28, 2026
jason810496
reviewed
Jun 29, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
LGTM once addresses the comments TP pointed out. Thanks.
A Java task may call the SDK client from multiple threads. Every call goes through one request/response channel to the supervisor. So it must be thread safe. Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
airflow-jdk-client-thread-safety
branch
from
June 29, 2026 07:54
5efb31c to
cd7020d
Compare
uranusjr
approved these changes
Jun 30, 2026
jason810496
approved these changes
Jul 1, 2026
1 task done
FrankYang0529
added a commit
to FrankYang0529/airflow
that referenced
this pull request
Jul 3, 2026
Serializing each client's whole send → receive → deserialize round trip behind one lock (apache#69080) allows only a single request in flight at a time, so a task issuing concurrent calls over the shared comm socket pays a full, serialized round trip per call. Every frame already carries a request id, so a single background dispatcher can read the socket and route each response by id, with the lock guarding only the write. Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
added a commit
to FrankYang0529/airflow
that referenced
this pull request
Jul 26, 2026
Serializing each client's whole send → receive → deserialize round trip behind one lock (apache#69080) allows only a single request in flight at a time, so a task issuing concurrent calls over the shared comm socket pays a full, serialized round trip per call. Every frame already carries a request id, so a single background dispatcher can read the socket and route each response by id, with the lock guarding only the write. Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
added a commit
to FrankYang0529/airflow
that referenced
this pull request
Jul 26, 2026
Serializing each client's whole send → receive → deserialize round trip behind one lock (apache#69080) allows only a single request in flight at a time, so a task issuing concurrent calls over the shared comm socket pays a full, serialized round trip per call. Every frame already carries a request id, so a single background dispatcher can read the socket and route each response by id, with the lock guarding only the write. Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
added a commit
to FrankYang0529/airflow
that referenced
this pull request
Jul 26, 2026
Serializing each client's whole send → receive → deserialize round trip behind one lock (apache#69080) allows only a single request in flight at a time, so a task issuing concurrent calls over the shared comm socket pays a full, serialized round trip per call. Every frame already carries a request id, so a single background dispatcher can read the socket and route each response by id, with the lock guarding only the write. Signed-off-by: PoAn Yang <payang@apache.org>
jason810496
pushed a commit
that referenced
this pull request
Jul 30, 2026
Serializing each client's whole send → receive → deserialize round trip behind one lock (#69080) allows only a single request in flight at a time, so a task issuing concurrent calls over the shared comm socket pays a full, serialized round trip per call. Every frame already carries a request id, so a single background dispatcher can read the socket and route each response by id, with the lock guarding only the write. Signed-off-by: PoAn Yang <payang@apache.org>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Aug 14, 2026
Serializing each client's whole send → receive → deserialize round trip behind one lock (apache#69080) allows only a single request in flight at a time, so a task issuing concurrent calls over the shared comm socket pays a full, serialized round trip per call. Every frame already carries a request id, so a single background dispatcher can read the socket and route each response by id, with the lock guarding only the write. Signed-off-by: PoAn Yang <payang@apache.org>
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
Serializing each client's whole send → receive → deserialize round trip behind one lock (apache#69080) allows only a single request in flight at a time, so a task issuing concurrent calls over the shared comm socket pays a full, serialized round trip per call. Every frame already carries a request id, so a single background dispatcher can read the socket and route each response by id, with the lock guarding only the write. Signed-off-by: PoAn Yang <payang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard the whole send/receive pair in
communicateImplwith aMutexso concurrent task threads are serialized over the single channel, and verify the response id echoes the request id to reject a mis-paired response.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.