Adding bg option to watershed#34
Open
rtobar wants to merge 1 commit into
Open
Conversation
This option replaces the hardcoded BG macro at the C level, giving users flexibility on the pixel value threshold to apply when finding pixels. This reduces the number of pixels to be inspected in images with low background noises. Tolerance is still defined in absolute terms. Note that we use the bg value not only to filter out which pixels are to be considered, but also to populate the frame array. This is important as it gives a more stable set of values to the sorting routine, yielding improved speed. I also took the opportunity of correctly aligning a couple of lines of code that had tabs in them and therefore were a bit off. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The work in this pull request comes from the fact that we are currently doing a watershed over slightly big images that need to be filtered first to cancel out some background noise.
To do that we do something like this:
The problem is that the cost of doing this filtering ourselves is a fair amount of the total cost:
Based on the median and mean values of these measurements we are observing an approximate filtering cost of 10%-15%.
Doing the watershed with the internal filtering (what we are proposing in this pull request) we should be able to do:
The cost is negligible, as the current watershed algorithm is already filtering positive pixels: