Skip to content

Reduce flickering on typing by reusing unchanged matches #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinliu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce flickering on typing by reusing unchanged matches #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions anyrun/src/plugin_box.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,21 @@ impl FactoryComponent for PluginBox {
{
let mut guard = self.matches.guard();

guard.clear();

for _match in matches {
guard.push_back((_match, self.config.clone()));
let len_new_matches = matches.len();
let len_old_matches = guard.len();
let mut skipped = 0;

while skipped < len_new_matches && skipped < len_old_matches {
if guard[skipped].content != matches[skipped] {
Comment thread
jinliu marked this conversation as resolved.
break;
}
skipped += 1;
}
while guard.len() > skipped {
guard.pop_back();
}
for _match in matches.iter().skip(skipped) {
guard.push_back((_match.clone(), self.config.clone()));
}
}
sender.output(PluginBoxOutput::MatchesLoaded).unwrap();
Expand Down
Loading