Add getAnimateUniforms() to CityBuildModel to enable sweep animation #2799
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CityBuildingLayercircular sweep animation effect was not displaying becauseCityBuildModellacked thegetAnimateUniforms()method, preventing dynamic updates of theu_timeuniform during the render loop.Changes
getAnimateUniforms()method toCityBuildModelclass, returning the current animation time viathis.layer.getLayerAnimateTime()IModelUniformtype from@antv/l7-coreImplementation follows the pattern used in
WaterModel,OceanModel, andFillModel:This enables the sweep animation in
site/examples/gallery/animate/demo/build_sweep.jsto render correctly.Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.