Skip to content

Rerun the search on Reset, and stop dumping logged-out users on the home page#201

Merged
mikessh merged 4 commits into
masterfrom
fix/browse-reset-and-login-redirect
Jul 23, 2026
Merged

Rerun the search on Reset, and stop dumping logged-out users on the home page#201
mikessh merged 4 commits into
masterfrom
fix/browse-reset-and-login-redirect

Conversation

@mikessh

@mikessh mikessh commented Jul 23, 2026

Copy link
Copy Markdown
Member

Four defects found walking the live site.

Reset filters left the table showing the old result set

reset() called filters.setDefault() and stopped. The panel cleared, the "Defaults changed"
marker went away, and the table below kept the previous filtered page and its Found: count.

Reproduced on production: filter MHC A by substring A*02Found: 143477. Press Reset
filters
→ chip gone, marker gone, counter still 143477. The two halves of the screen state
different things and the number people quote is the stale one.

Now re-runs the search, which costs the same one search that Refresh table already does.

Logged-out /annotations redirected to the home page

SessionAction.authorizedOnly sent unauthenticated requests to Application.index(). Opening
/annotations while logged out lands you on the front page with no message — it reads as a broken
link, not as "you need an account".

Now goes to Authorization.temporaryLogin, the same page the navbar's Login points at. Covers
every authorizedOnly call site: /annotations/*, Account.detailsPage, Account.changePassword,
logout, and the upload API. unauthorizedOnly (already-logged-in hitting a signup page) still
goes home, which is correct.

Two specs pinned the old target and now pin the new one; SessionActionSpec gained a comment
saying why, because "redirect somewhere" passed for years while the somewhere was wrong.

Evidence group titles were centred while stacked

The inner grid is ui three column stackable — below 768px it collapses to one column, and the
inline text-align: center left "Validation" floating in the middle of the panel with its own
checkboxes hard against the left edge. Left-aligned now, which sits above its own column at every
width.

Motif and structure Export buttons were illegible

opacity: 0.4 over rgba(0, 0, 0, 0.6) text ≈ 1.7:1 against white, well under the 4.5:1 floor.
They are not disabled — they are hover-to-reveal, and on touch there is no hover at all. I read them
as disabled myself before checking the DOM. 0.75 at rest, 1 on hover.

Verification

  • sbt test213 passed, 0 failed (1 canceled, pre-existing).
  • Backend compile clean under -Xfatal-warnings.
  • Frontend has no local build (node 11 + yarn 1.x); CI is the compile gate.
  • The Reset and redirect defects were both reproduced against live production first.

Not fixed, found while looking

  • Browse pagination and the Found:/Total: counters live inside the table's <th>, so on a phone
    they scroll sideways out of view with the table.
  • The disabled paired-chain + keeps cursor: pointer.
  • Motif sidebar Collapse all / Clear selection are ui blue / ui orange — off-brand, and part
    of the deferred --ds-* token migration rather than a one-off.

🤖 Generated with Claude Code

mikessh and others added 4 commits July 23, 2026 09:59
…ome page

Four things found walking the live site.

**Reset filters left the table showing the old result set.** `reset()` called
`filters.setDefault()` and stopped there, so the panel cleared, the "Defaults changed"
marker went away, and the table below kept the previous filtered page and its "Found:"
count. Filter A*02, get 143,477, press Reset - the form says no filters and the counter
still says 143,477. It re-runs the search now, which is the same one search "Refresh
table" already costs.

**Logged-out /annotations redirected to the home page.** Everything behind
`authorizedOnly` is reached by someone who has already decided to do something needing an
account. Answering with the front page explains nothing: the address bar changes, no
message appears, and it reads as a broken link. It goes to the login page now - the same
one the navbar's Login points at - which covers /annotations, the account pages and
logout alike. Two specs pinned the old target and now pin the new one.

**The Evidence group titles were centred while stacked.** `stackable` collapses that
inner grid to one column below 768px, and a centred "Validation" over left-aligned
checkboxes reads as a stray heading floating mid-panel with its boxes nowhere near it.
Left-aligned sits above its own column at every width.

**The motif and structure Export buttons rendered at opacity 0.4** over
`rgba(0,0,0,0.6)` text - about 1.7:1 against white, well under the 4.5:1 floor. They are
not disabled, they are hover-to-reveal, and on touch there is no hover at all. 0.75 at
rest, 1 on hover.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The burger menu is a CSS `:checked` disclosure with no component state behind it, which is
what lets it work without script - and also means nothing ever unchecks it. Tapping "Motif"
routes to the motif page and leaves the full-height menu sitting on top of it: the page you
asked for is hidden behind the menu you used to ask for it, and you have to find the burger
again to see it. Reproduced on production at 674px.

Unchecked on NavigationEnd, in the subscription that already tracks the current URL for the
active-tab highlight. The `external="true"` items reload the document and reset the checkbox
by themselves; these are the ones that don't.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ating

"Select up to 5 structures from 3706 . Click a card to add/remove a structure from
overlay" - the three spans sit on separate source lines, and the indentation between
them renders as a space, so the separator reads as a full stop with a gap in front of
it. Joined, with an explicit `&nbsp;` for the space that is wanted.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…inline centre

`.filters.label` is `text-align: right` in semantic-extensions.css, so dropping the
inline `text-align: center` sent the three titles to the far right of their columns -
further from their own checkboxes than centring had them. Say left.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mikessh
mikessh merged commit c351ad1 into master Jul 23, 2026
1 check passed
@mikessh
mikessh deleted the fix/browse-reset-and-login-redirect branch July 23, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant