Rerun the search on Reset, and stop dumping logged-out users on the home page#201
Merged
Merged
Conversation
…ome page Four things found walking the live site. **Reset filters left the table showing the old result set.** `reset()` called `filters.setDefault()` and stopped there, so the panel cleared, the "Defaults changed" marker went away, and the table below kept the previous filtered page and its "Found:" count. Filter A*02, get 143,477, press Reset - the form says no filters and the counter still says 143,477. It re-runs the search now, which is the same one search "Refresh table" already costs. **Logged-out /annotations redirected to the home page.** Everything behind `authorizedOnly` is reached by someone who has already decided to do something needing an account. Answering with the front page explains nothing: the address bar changes, no message appears, and it reads as a broken link. It goes to the login page now - the same one the navbar's Login points at - which covers /annotations, the account pages and logout alike. Two specs pinned the old target and now pin the new one. **The Evidence group titles were centred while stacked.** `stackable` collapses that inner grid to one column below 768px, and a centred "Validation" over left-aligned checkboxes reads as a stray heading floating mid-panel with its boxes nowhere near it. Left-aligned sits above its own column at every width. **The motif and structure Export buttons rendered at opacity 0.4** over `rgba(0,0,0,0.6)` text - about 1.7:1 against white, well under the 4.5:1 floor. They are not disabled, they are hover-to-reveal, and on touch there is no hover at all. 0.75 at rest, 1 on hover. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The burger menu is a CSS `:checked` disclosure with no component state behind it, which is what lets it work without script - and also means nothing ever unchecks it. Tapping "Motif" routes to the motif page and leaves the full-height menu sitting on top of it: the page you asked for is hidden behind the menu you used to ask for it, and you have to find the burger again to see it. Reproduced on production at 674px. Unchecked on NavigationEnd, in the subscription that already tracks the current URL for the active-tab highlight. The `external="true"` items reload the document and reset the checkbox by themselves; these are the ones that don't. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ating "Select up to 5 structures from 3706 . Click a card to add/remove a structure from overlay" - the three spans sit on separate source lines, and the indentation between them renders as a space, so the separator reads as a full stop with a gap in front of it. Joined, with an explicit ` ` for the space that is wanted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…inline centre `.filters.label` is `text-align: right` in semantic-extensions.css, so dropping the inline `text-align: center` sent the three titles to the far right of their columns - further from their own checkboxes than centring had them. Say left. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four defects found walking the live site.
Reset filters left the table showing the old result set
reset()calledfilters.setDefault()and stopped. The panel cleared, the "Defaults changed"marker went away, and the table below kept the previous filtered page and its
Found:count.Reproduced on production: filter MHC A by substring
A*02→Found: 143477. Press Resetfilters → chip gone, marker gone, counter still 143477. The two halves of the screen state
different things and the number people quote is the stale one.
Now re-runs the search, which costs the same one search that Refresh table already does.
Logged-out
/annotationsredirected to the home pageSessionAction.authorizedOnlysent unauthenticated requests toApplication.index(). Opening/annotationswhile logged out lands you on the front page with no message — it reads as a brokenlink, not as "you need an account".
Now goes to
Authorization.temporaryLogin, the same page the navbar's Login points at. Coversevery
authorizedOnlycall site:/annotations/*,Account.detailsPage,Account.changePassword,logout, and the upload API.unauthorizedOnly(already-logged-in hitting a signup page) stillgoes home, which is correct.
Two specs pinned the old target and now pin the new one;
SessionActionSpecgained a commentsaying why, because "redirect somewhere" passed for years while the somewhere was wrong.
Evidence group titles were centred while stacked
The inner grid is
ui three column stackable— below 768px it collapses to one column, and theinline
text-align: centerleft "Validation" floating in the middle of the panel with its owncheckboxes hard against the left edge. Left-aligned now, which sits above its own column at every
width.
Motif and structure Export buttons were illegible
opacity: 0.4overrgba(0, 0, 0, 0.6)text ≈ 1.7:1 against white, well under the 4.5:1 floor.They are not disabled — they are hover-to-reveal, and on touch there is no hover at all. I read them
as disabled myself before checking the DOM. 0.75 at rest, 1 on hover.
Verification
sbt test— 213 passed, 0 failed (1 canceled, pre-existing).-Xfatal-warnings.Not fixed, found while looking
Found:/Total:counters live inside the table's<th>, so on a phonethey scroll sideways out of view with the table.
+keepscursor: pointer.Collapse all/Clear selectionareui blue/ui orange— off-brand, and partof the deferred
--ds-*token migration rather than a one-off.🤖 Generated with Claude Code