-
Notifications
You must be signed in to change notification settings - Fork 79
chore(CI): add example check on asan test #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Reviewer's GuideAdds two new CI jobs to run ASan-instrumented example binaries for x86 and AArch64 artifacts in the GitHub Actions workflow. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The
for example in ./*; doloop will iterate over directories and non-binaries as well; consider restricting to regular files (e.g. viafind . -maxdepth 1 -type f -executable) and quoting$exampleto avoid issues with spaces or non-executable entries. - The
test_example_x86andtest_example_aarch64jobs are nearly identical; consider factoring the common steps into a matrix job or a reusable workflow to reduce duplication and keep the two architectures in sync more easily.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `for example in ./*; do` loop will iterate over directories and non-binaries as well; consider restricting to regular files (e.g. via `find . -maxdepth 1 -type f -executable`) and quoting `$example` to avoid issues with spaces or non-executable entries.
- The `test_example_x86` and `test_example_aarch64` jobs are nearly identical; consider factoring the common steps into a matrix job or a reusable workflow to reduce duplication and keep the two architectures in sync more easily.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1381 +/- ##
==========================================
- Coverage 91.66% 91.66% -0.01%
==========================================
Files 325 325
Lines 18630 18569 -61
==========================================
- Hits 17077 17021 -56
+ Misses 1553 1548 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2b39345 to
982bf3d
Compare
wxyucs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4bb9e53 to
9cd23b0
Compare
cf4521c to
223e070
Compare
b2dfd30 to
607c521
Compare
Signed-off-by: LHT129 <[email protected]>
Summary by Sourcery
Add CI jobs to run ASan-instrumented example binaries on both x86 and AArch64 builds.
CI: