introduce CompileOptions, StrictEOF option #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is a bit too forgiving for our use case. The particular issue that brought this to light was that an XPath expression like
//foo,garbagewill be parsed without issues. I propose the changes in this PR so that such expressions can be optionally rejected, while maintaining backward compatibility.
New versions of public functions are introduced that take the newly introduced CompileOptions parameter, with a single available option for now (the one that we needed for the case above).
There is another PR in the xmlquery repo to go with this one.