Conversation
d10e214 to
83554a6
Compare
SMoraisAnsys
left a comment
There was a problem hiding this comment.
@jorgepiloto I think you only have to change the file name to have your changes working
Regarding the changes, I don't have a strong opinion and am fine with the proposed changes.
| SANITIZED_NAME="${LIBRARY_NAME}" | ||
| SANITIZED_NAME="${SANITIZED_NAME//-/_}" |
There was a problem hiding this comment.
Would that work instead?
| SANITIZED_NAME="${LIBRARY_NAME}" | |
| SANITIZED_NAME="${SANITIZED_NAME//-/_}" | |
| SANITIZED_NAME="${LIBRARY_NAME//-/_}" |
RobPasMue
left a comment
There was a problem hiding this comment.
We should also check that other actions like the GitHub release are not impacted by this change. I'm not sure what naming convention it was expecting for wheelhouse artifacts.
Good point. So far, I checked the release ones. They use a glob pattern like |
There is no convention for wheelhouses as opposite to Python distribution artifacts. Knowing that these last impose underscores in the name of the projects but use hyphens for separating metadata, I decided to follow the same approach with the wheelhouse. Fixes #681.