Skip to content

feat: update wheelhouse artifacts names#1112

Open
jorgepiloto wants to merge 4 commits intomainfrom
feat/unify-artifact-names
Open

feat: update wheelhouse artifacts names#1112
jorgepiloto wants to merge 4 commits intomainfrom
feat/unify-artifact-names

Conversation

@jorgepiloto
Copy link
Member

There is no convention for wheelhouses as opposite to Python distribution artifacts. Knowing that these last impose underscores in the name of the projects but use hyphens for separating metadata, I decided to follow the same approach with the wheelhouse. Fixes #681.

@jorgepiloto jorgepiloto requested a review from a team as a code owner January 14, 2026 14:44
@github-actions github-actions bot added the enhancement General improvements to existing features label Jan 14, 2026
@jorgepiloto jorgepiloto force-pushed the feat/unify-artifact-names branch from d10e214 to 83554a6 Compare January 14, 2026 14:48
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgepiloto I think you only have to change the file name to have your changes working

Regarding the changes, I don't have a strong opinion and am fine with the proposed changes.

Comment on lines +356 to +357
SANITIZED_NAME="${LIBRARY_NAME}"
SANITIZED_NAME="${SANITIZED_NAME//-/_}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that work instead?

Suggested change
SANITIZED_NAME="${LIBRARY_NAME}"
SANITIZED_NAME="${SANITIZED_NAME//-/_}"
SANITIZED_NAME="${LIBRARY_NAME//-/_}"

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check that other actions like the GitHub release are not impacted by this change. I'm not sure what naming convention it was expecting for wheelhouse artifacts.

@jorgepiloto
Copy link
Member Author

We should also check that other actions like the GitHub release are not impacted by this change. I'm not sure what naming convention it was expecting for wheelhouse artifacts.

Good point. So far, I checked the release ones. They use a glob pattern like *-wheelhouse-*, so we should be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify artifacts file names

5 participants