feat: check version match #1111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
RobPasMue
reviewed
Jan 14, 2026
Comment on lines
+179
to
+180
| ARTIFACT_VERSION="$(basename "${ARTIFACT_FILE}" \ | ||
| | sed -E 's/^[^-]+-([0-9][0-9A-Za-z\.\-_]*).*/\1/')" |
Member
There was a problem hiding this comment.
I think we might have to revisit this regex... I might be wrong but it's giving me some issues when I try it out
MaxJPRey
reviewed
Jan 14, 2026
| name: ${{ inputs.library-name }}-artifacts | ||
| path: ${{ inputs.library-name }}-artifacts | ||
|
|
||
| - name: "Verify tag and artifacts version agree" |
Contributor
There was a problem hiding this comment.
Suggested change
| - name: "Verify tag and artifacts version agree" | |
| - name: "Verify tag and artifacts version match" |
SMoraisAnsys
requested changes
Jan 27, 2026
Contributor
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Thanks for this PR @jorgepiloto, I think that the current version extraction is not working. Can you update it ? Trying it on the proposed example (ansys-project-1.2.3-py3-none-any.whl) does behave as I would expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #671 by making sure artifacts version matches the git tag that triggered a release.