fix(code-style): use uv sync if lock file is present#1088
Open
jorgepiloto wants to merge 6 commits intomainfrom
Open
fix(code-style): use uv sync if lock file is present#1088jorgepiloto wants to merge 6 commits intomainfrom
jorgepiloto wants to merge 6 commits intomainfrom
Conversation
github-actions
bot
added
the
fix
moe-ad
reviewed
Dec 3, 2025
Comment on lines
+253
to
+257
| if [ -f "uv.lock" ]; then | ||
| uv sync | ||
| else | ||
| uv pip install . | ||
| fi |
Contributor
There was a problem hiding this comment.
@jorgepiloto I was wondering if we could extend this to _doc-build-linux, _doc-build-windows, build-wheelhouse, check-vulnerabilities, and tests-pytest. Those are the actions I have noted where something similar to this might be needed (I am not sure if I am missing some others).
Or we could address those in a separate PR if that is what you prefer.
da1910
requested changes
Jan 27, 2026
| elif [[ "${BUILD_BACKEND}" == 'uv' ]]; then | ||
| uv pip install ."${extra_targets}" | ||
| if [ -f "uv.lock" ]; then | ||
| uv sync --extra "${extra_targets}" |
There was a problem hiding this comment.
Suggested change
| uv sync --extra "${extra_targets}" | |
| uv sync --extra "${extra_targets}" --frozen |
If we're using the lock file we need to not regenerate it when we sync
| elif [[ "${BUILD_BACKEND}" == 'uv' ]]; then | ||
| uv pip install . | ||
| if [ -f "uv.lock" ]; then | ||
| uv sync |
There was a problem hiding this comment.
Suggested change
| uv sync | |
| uv sync --frozen |
| run: | | ||
| ${ACTIVATE_VENV} | ||
| if [[ "${USE_UV}" == 'true' ]]; then | ||
| uv pip install -U pip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #926 by using
uv pip installoruv syncdepending on whether auv.lockfile is present.