Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the action handling system by replacing screen-specific action interfaces with a common ScreenCommonAction approach, consolidating action types and improving code reusability across different screens.
Key changes:
- Replaces custom action interfaces (
WishListAction,WatchListAction,SearchViewAction, etc.) withScreenCommonAction - Introduces
onScreenCommonAction()helper function for standardized action handling - Consolidates action creation through helper functions (
startActivityAction,showToastAction,showSnackbarAction)
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib | Subproject commit update |
| app/build.gradle.kts | Version code increment |
| WishListViewModel.kt | Removed custom WishListAction interface, migrated to ScreenCommonAction |
| WishListScreen.kt | Simplified action handling using onScreenCommonAction helper |
| WatchListStateViewModel.kt | Removed custom WatchListAction interface and local action helper functions |
| MainScreen.kt | Replaced manual action handling with onScreenCommonAction helper |
| ShowSnackbarAction.kt | New file defining PlainShowSnackbarData and showSnackbarAction helper |
| UserLogScreen.kt | Added required navigateTo parameter to onScreenCommonAction |
| TagWatchListScreen.kt | Simplified action handling using onScreenCommonAction |
| TagSnackbar.kt | Updated to use TagSnackbarAppInfo data class |
| SchedulesHistoryScreen.kt | Added navigateTo parameter and fixed layout modifier |
| SearchViewModel.kt | Removed SearchViewAction interface, refactored event handling |
| SearchResultsScreen.kt | Simplified action handling with onScreenCommonAction |
| SceneNavKey.kt | Added ScreenCommonNavKey extension and asNavKey conversion |
| InstalledListViewModel.kt | Removed custom action interface and simplified back press handling |
| InstalledListScreen.kt | Added navigateTo parameter support |
| HistoryListViewModel.kt | Removed HistoryListAction interface, migrated to ScreenCommonAction |
| HistoryListScreen.kt | Added navigateTo parameter and simplified action handling |
| DetailsViewModel.kt | Updated ShowTagSnackbar to use TagSnackbarAppInfo wrapper |
| DetailsPanel.kt | Updated to access app through TagSnackbarAppInfo wrapper |
| AccountSelectionRequest.kt | Added AccountSelectionDialogData and showAccountSelectionAction |
| AppWatcherActivity.kt | Added navigateTo parameters to screen scenes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.