refactor(aria/combobox): allow custom popup triggering logic (#32493)#33198
Open
tjshiu wants to merge 1 commit intoangular:mainfrom
Open
refactor(aria/combobox): allow custom popup triggering logic (#32493)#33198tjshiu wants to merge 1 commit intoangular:mainfrom
tjshiu wants to merge 1 commit intoangular:mainfrom
Conversation
tjshiu
added
the
dev-app preview
…#32493) - Adds `trigger` input to support custom trigger elements (like dropdown buttons). - Updates blur check logic to protect focus within custom popup triggering zones. - Introduces a new custom trigger button component example.
tjshiu
force-pushed
the
customPopupTriggeringLogic
branch
from
726952e to
0a5903a
Compare
|
Deployed dev-app for 0a5903a to: https://ng-dev-previews-comp--pr-angular-components-33198-dev-t91qjucx.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
ok7sai
reviewed
May 5, 2026
| readonly openOnInput = input(true, {transform: booleanAttribute}); | ||
|
|
||
| /** Optional trigger element associated with the combobox. */ | ||
| readonly trigger = input<HTMLElement | undefined>(undefined); |
Member
There was a problem hiding this comment.
I feel these two APIs are for niche use cases that need more discussion. Let's discuss in the sync.
Contributor
Author
There was a problem hiding this comment.
yeah - I can see that: It's related to this: #32493
I added an example for dev-app preview, which adds a trigger button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
triggerinput to support custom trigger elements (like dropdown buttons).