Guard the seam packages against t.Parallel#280
Merged
Conversation
andyrewlee
force-pushed
the
ui-seam-parallel-guard
branch
from
f5f9fa2 to
fb2c231
Compare
andyrewlee
force-pushed
the
tmux-enterdelay-seam
branch
from
44b3cec to
ad8590f
Compare
andyrewlee
force-pushed
the
ui-seam-parallel-guard
branch
from
fb2c231 to
814e80c
Compare
andyrewlee
force-pushed
the
tmux-enterdelay-seam
branch
from
ad8590f to
91f1796
Compare
andyrewlee
force-pushed
the
ui-seam-parallel-guard
branch
from
814e80c to
59e9412
Compare
andyrewlee
force-pushed
the
tmux-enterdelay-seam
branch
from
91f1796 to
d06b1a7
Compare
andyrewlee
force-pushed
the
ui-seam-parallel-guard
branch
from
59e9412 to
86853f0
Compare
andyrewlee
force-pushed
the
tmux-enterdelay-seam
branch
from
d06b1a7 to
b3305f7
Compare
andyrewlee
force-pushed
the
ui-seam-parallel-guard
branch
from
86853f0 to
843e87e
Compare
andyrewlee
force-pushed
the
tmux-enterdelay-seam
branch
from
b3305f7 to
16ac4c1
Compare
andyrewlee
force-pushed
the
ui-seam-parallel-guard
branch
from
843e87e to
77dbe9b
Compare
andyrewlee
force-pushed
the
tmux-enterdelay-seam
branch
from
16ac4c1 to
035d4eb
Compare
andyrewlee
force-pushed
the
ui-seam-parallel-guard
branch
from
77dbe9b to
5c06eb1
Compare
internal/ui/center and internal/ui/sidebar route tmux capture/resize/ reattach through mutable package-global test seams that tests override and restore via defer. A test that adds t.Parallel in these packages would race those shared seams and pass or fail spuriously — masking or faking a real reattach bug. The constraint was only a comment on the seam declarations, with nothing enforcing it. Add a self-contained guard test in each package that scans its own *_test.go files and fails if any introduces t.Parallel(), turning a silent footgun into a build break. (A global forbidigo rule was avoided because t.Parallel is correct and wanted elsewhere.) Verified it fails on a planted t.Parallel and passes once removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
andyrewlee
force-pushed
the
ui-seam-parallel-guard
branch
from
5c06eb1 to
01a9be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close-the-loop stack — PR 9/12
Problem
internal/ui/centerandinternal/ui/sidebarroute tmux capture/resize/reattach through mutable package-global test seams that tests override and restore viadefer. A test that addst.Parallelin these packages would race those shared seams and pass/fail spuriously — masking or faking a real reattach bug. The constraint was only a comment on the seam declarations, with nothing enforcing it.Change
A self-contained guard test in each package scans its own
*_test.gofiles and fails if any introducest.Parallel(). A global forbidigo rule was avoided becauset.Parallelis correct and wanted elsewhere in the repo.Verification
Confirmed it fails on a planted
t.Parallel()and passes once removed.🤖 Generated with Claude Code