HelloAndroidXR update for May 2026#32
Merged
Merged
Conversation
- Updated BugdroidModel to use new SpatialGltfModel instead of SceneCoreEntity - Updated BugdroidViewModel so 'Reset' functionality will stop the glTF animation - Reorganized assets to adhere to best practices Change-Id: I0d610f9e3b467ad614312127cbe1bfefb5552a34
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors 3D model handling by replacing the custom controller with the new SpatialGltfModel API and updates spatial layout modifiers to use the latest movable and resizable components. It also includes library version bumps and minor UI logic adjustments. Feedback highlights several critical issues: the window size logic incorrectly uses a height constant for width checks, asset loading via Paths.get() is incompatible with Android assets, materials are unsafely reused across different XR sessions, and a missing LaunchedEffect key prevents the bugdroid animation from responding to state changes.
…droidModel.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
fuentespatrick
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.