Bugfix/typoscript settings maillog#85
Conversation
…ssages per process
…ssages per process
| "require": { | ||
| "php": "~8.3.0 || ~8.4.0 || ~8.5.0", | ||
| "composer-runtime-api": "^2", | ||
| "typo3/cms-core": "^12.4.0 || ^13.4.0", |
There was a problem hiding this comment.
needs to change in ext_emconf.php aswell
| return $normalizedPaths; | ||
| } | ||
|
|
||
| private function getRequest(): ServerRequestInterface |
There was a problem hiding this comment.
DRY: TemplateBasedMailMessage::getRequest(), ConfigurationUtility::getRequest(), CleanupSettingsService::createBackendRequest()
|
One thing I'd clarify before merging: IMHO the double logging does not come from the shared |
|
A caveat about the new spool path that should at least be documented: Since the core fix for CVE-2026-0859, This is not introduced by this PR - it happens whenever the extension is used with file spool. Since |
| $this->configurationManager->setRequest($this->createBackendRequest()); | ||
| } | ||
|
|
||
| return $this->configurationManager->getConfiguration( |
There was a problem hiding this comment.
Previously there was a catch for RuntimeException, now there isn't. Intended?
Also, not sure about possible in-process side-effects by setting the request globally
| #[Override] | ||
| protected function setUp(): void | ||
| { | ||
| putenv('typo3DatabaseDriver=pdo_sqlite'); |
There was a problem hiding this comment.
phpunit.xml -> <env name="typo3DatabaseDriver" value="pdo_sqlite"/>?
|
|
||
| class LoggingTransport implements TransportInterface | ||
| { | ||
| protected MailLog $mailLog; |
There was a problem hiding this comment.
Not yet an issue, but accessing this before call to send() will except with TypeError.
How about protected ?MailLog $mailLog = null;?
No description provided.