Skip to content

Fix makeInstance DI for BackendConfigurationManager#80

Merged
smirgol merged 1 commit into
masterfrom
fix-backend-configuration-manager-di
Feb 23, 2026
Merged

Fix makeInstance DI for BackendConfigurationManager#80
smirgol merged 1 commit into
masterfrom
fix-backend-configuration-manager-di

Conversation

@smirgol

@smirgol smirgol commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

ConfigurationUtility is calling makeInstance on BackendConfigurationManager, but that service is defined as public: false.
Since it requires constructor args for instantiating, makeInstance throws an exception.
This patch works around the issue and works for typo3 v12 and v13. Had to use reflection though, as the parameter count differs between v12 and v13.

@smirgol
smirgol requested a review from weakbit February 2, 2026 14:55

@weakbit weakbit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail

@smirgol
smirgol force-pushed the fix-backend-configuration-manager-di branch from 5470b47 to 5dbf71d Compare February 4, 2026 14:32
@smirgol

smirgol commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

still not a nice solution, but gets the job done

@smirgol
smirgol requested a review from weakbit February 4, 2026 14:45
@smirgol
smirgol merged commit 83e3fe6 into master Feb 23, 2026
12 checks passed
@Kanti
Kanti deleted the fix-backend-configuration-manager-di branch February 23, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants