Skip to content

Add ObjectExplicitBoolCompareRector and ArrayExplicitBoolCompareRector to skip list#112

Merged
Kanti merged 4 commits into
mainfrom
copilot/fix-php-8-2-typo3-failure
Jul 13, 2026
Merged

Add ObjectExplicitBoolCompareRector and ArrayExplicitBoolCompareRector to skip list#112
Kanti merged 4 commits into
mainfrom
copilot/fix-php-8-2-typo3-failure

Conversation

Copilot AI commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Adds ArrayExplicitBoolCompareRector to the Rector skip list, consistent with the existing skips for ExplicitBoolCompareRector and ObjectExplicitBoolCompareRector.

Changes

  • src/RectorSettings.php: Import Rector\CodeQuality\Rector\If_\ArrayExplicitBoolCompareRector and add it to skip(), preventing Rector from transforming:
    // FROM
    if ($array) { ... }
    // TO
    if ($array !== []) { ... }

Copilot AI changed the title [WIP] Fix failing GitHub Actions job php: 8.2 TYPO3: false Skip ObjectExplicitBoolCompareRector in shared Rector config Jul 13, 2026
Copilot AI requested a review from Kanti July 13, 2026 06:24
Copilot finished work on behalf of Kanti July 13, 2026 06:24
Copilot AI changed the title Skip ObjectExplicitBoolCompareRector in shared Rector config Add ArrayExplicitBoolCompareRector to skip list Jul 13, 2026
Copilot finished work on behalf of Kanti July 13, 2026 06:27
Copilot AI requested a review from Kanti July 13, 2026 06:27
@Kanti Kanti changed the title Add ArrayExplicitBoolCompareRector to skip list Add ObjectExplicitBoolCompareRector and ArrayExplicitBoolCompareRector to skip list Jul 13, 2026
@Kanti
Kanti marked this pull request as ready for review July 13, 2026 06:29
@Kanti
Kanti merged commit 631ed1d into main Jul 13, 2026
50 checks passed
@Kanti
Kanti deleted the copilot/fix-php-8-2-typo3-failure branch July 13, 2026 06:30
Copilot stopped work on behalf of Kanti due to an error July 13, 2026 06:31
Copilot stopped work on behalf of Kanti due to an error July 13, 2026 06:31
Kanti added a commit that referenced this pull request Jul 13, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants