🛡️ Sentinel: [CRITICAL] Fix PDF compilation RCE vulnerability

[anchapin]

🚨 Severity: CRITICAL\n💡 Vulnerability: PDF compilation via pdflatex and pandoc lacked restricted execution flags (-no-shell-escape), allowing potential Remote Code Execution (RCE) via \write18 or shell-escape attacks if malicious LaTeX is compiled.\n🎯 Impact: An attacker could execute arbitrary system commands on the server during the PDF generation process.\n🔧 Fix: Added the -no-shell-escape flag to pdflatex and --pdf-engine-opt=-no-shell-escape to pandoc commands in cli/pdf/converter.py and cli/generators/cover_letter_generator.py. Also handled subprocess.TimeoutExpired properly to prevent infinite processes.\n✅ Verification: The modifications prevent RCE and the test_pdf_security.py tests have passed successfully.

---

PR created automatically by Jules for task 12750106391259952737 started by @anchapin

Summary by Sourcery

Harden PDF generation against remote code execution by sandboxing LaTeX engine subprocesses and enforcing timeouts.

Bug Fixes:

• Prevent potential RCE during PDF compilation by passing -no-shell-escape to pdflatex and pandoc LaTeX engine invocations.
• Avoid hung LaTeX compilation processes by adding timeouts and killing stalled subprocesses in PDF generation flows.

Enhancements:

• Document the newly identified PDF compilation RCE class of vulnerabilities and corresponding mitigation patterns in the Sentinel security notes.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sourcery-ai]

Reviewer's Guide

Harden PDF compilation by disabling LaTeX shell escape in all pdflatex/pandoc subprocesses and adding timeout handling to avoid hanging or exploitable processes, while documenting the vulnerability in Sentinel notes.

Sequence diagram for hardened PDF compilation subprocess

sequenceDiagram
    participant Generator as CoverLetterGenerator
    participant Subprocess as subprocess
    participant Pdflatex as pdflatex_process

    Generator->>Subprocess: Popen(["pdflatex", "-interaction=nonstopmode", "-no-shell-escape", tex_path.name])
    Subprocess-->>Pdflatex: start_process

    Generator->>Pdflatex: communicate(timeout=30)
    alt TimeoutExpired
        Generator->>Pdflatex: kill()
        Generator->>Pdflatex: communicate()
        Generator-->>Generator: return False
    else Completed
        Pdflatex-->>Generator: returncode, stdout, stderr
        alt success_or_output_path_exists
            Generator-->>Generator: pdf_created = True
        else failure
            Generator->>Subprocess: Popen(["pandoc", tex_path, "-o", output_path, "--pdf-engine=xelatex", "--pdf-engine-opt=-no-shell-escape"])
            Subprocess-->>Pdflatex: start_pandoc_process
            Generator->>Pdflatex: communicate(timeout=30)
            alt TimeoutExpired
                Generator->>Pdflatex: kill()
                Generator->>Pdflatex: communicate()
                Generator-->>Generator: return False
            else Completed
                Pdflatex-->>Generator: returncode, stdout, stderr
                alt success_or_output_path_exists
                    Generator-->>Generator: pdf_created = True
                else failure
                    Generator-->>Generator: pdf_created = False
                end
            end
        end
    end

Loading

File-Level Changes

Change	Details	Files
Lock down pdflatex and pandoc invocations in the cover letter generator to prevent shell-escape RCE and hanging compilation processes.	Add -no-shell-escape flag to the pdflatex command used for cover letter PDF generation. Add --pdf-engine-opt=-no-shell-escape to the pandoc command used as a PDF generation fallback. Wrap subprocess.communicate calls with a 30-second timeout and kill the process on TimeoutExpired, returning False when compilation stalls.	cli/generators/cover_letter_generator.py
Apply the same hardened PDF compilation behavior to the generic PDF converter utilities.	Add -no-shell-escape flag to the pdflatex command used in the core PDF converter. Add --pdf-engine-opt=-no-shell-escape to the pandoc command used in the core PDF converter. Add 30-second timeout handling around subprocess.communicate and ensure stalled processes are killed and treated as failures.	cli/pdf/converter.py
Document the PDF compilation RCE vulnerability and its mitigation in the Sentinel security notes.	Add a new Sentinel entry describing the missing shell-escape restrictions in LaTeX PDF compilation. Record the security learning that LaTeX subprocess calls must always disable shell escape. Note the preventive pattern: always pass -no-shell-escape and handle compilation timeouts safely.	.jules/sentinel.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.