🛡️ Sentinel: [CRITICAL] Fix LaTeX RCE vulnerability

[anchapin]

🚨 Severity: CRITICAL
💡 Vulnerability: LaTeX compilation commands (pdflatex and pandoc) lacked the -no-shell-escape flag, allowing potential Remote Code Execution (RCE) from untrusted LaTeX documents.
🎯 Impact: An attacker could execute arbitrary shell commands on the server generating the PDFs.
🔧 Fix: Added -no-shell-escape and --pdf-engine-opt=-no-shell-escape to all PDF compilation subprocess calls.
✅ Verification: Ensured the tests pass and code is formatted correctly.

---

PR created automatically by Jules for task 18166002057815175540 started by @anchapin

Summary by Sourcery

Harden LaTeX PDF generation against remote code execution by disabling shell escapes in all compilation paths and documenting the vulnerability and mitigation steps.

Enhancements:

• Ensure all pdflatex subprocess calls compile with shell escape explicitly disabled.
• Ensure all pandoc-based PDF generation invokes xelatex with shell escape disabled via engine options.
• Add inline security comments to LaTeX compilation code paths for future maintainers.

Documentation:

• Extend Sentinel security notes with a new entry describing the LaTeX RCE risk and the requirement to use no-shell-escape flags during compilation.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sourcery-ai]

Reviewer's Guide

Adds explicit LaTeX shell-escape hardening to all PDF generation paths by updating pdflatex/pandoc subprocess invocations and documenting the RCE class of vulnerability in the Sentinel security log.

Sequence diagram for hardened LaTeX PDF compilation

sequenceDiagram
    actor User
    participant CoverLetterGenerator
    participant PdfConverter
    participant subprocess
    participant pdflatex
    participant pandoc

    User->>CoverLetterGenerator: generate_cover_letter
    CoverLetterGenerator->>CoverLetterGenerator: _compile_pdf
    CoverLetterGenerator->>subprocess: Popen(pdflatex -interaction=nonstopmode -no-shell-escape)
    subprocess->>pdflatex: pdflatex -no-shell-escape
    pdflatex-->>CoverLetterGenerator: PDF success or failure

    CoverLetterGenerator->>PdfConverter: _compile_pdflatex / _compile_pandoc
    PdfConverter->>subprocess: Popen(pdflatex -interaction=nonstopmode -no-shell-escape)
    subprocess->>pdflatex: pdflatex -no-shell-escape
    pdflatex-->>PdfConverter: PDF success or failure

    PdfConverter->>subprocess: Popen(pandoc --pdf-engine=xelatex --pdf-engine-opt=-no-shell-escape)
    subprocess->>pandoc: pandoc --pdf-engine-opt=-no-shell-escape
    pandoc-->>PdfConverter: PDF success or failure

Loading

File-Level Changes

Change	Details	Files
Harden pdflatex invocations against RCE in cover letter PDF generation and generic PDF conversion.	Add a security comment explaining RCE prevention for LaTeX compilation subprocesses. Inject the -no-shell-escape flag into all pdflatex subprocess.Popen calls used for PDF compilation. Ensure working directory and other subprocess parameters remain unchanged aside from the new flag.	cli/generators/cover_letter_generator.py cli/pdf/converter.py
Harden pandoc-based LaTeX->PDF compilation against RCE.	Add a security comment explaining RCE prevention for pandoc-based LaTeX compilation. Extend pandoc command-line arguments to include --pdf-engine-opt=-no-shell-escape in all PDF compilation paths. Preserve existing pdf-engine=xelatex configuration while adding RCE protections.	cli/generators/cover_letter_generator.py cli/pdf/converter.py
Document the LaTeX compilation RCE vulnerability and mitigation in the Sentinel security log.	Add a dated entry describing the RCE class of vulnerability via LaTeX compilers when shell escape is not disabled. Record the security learning about compiling untrusted LaTeX and its risks. Document the preventive measure of always using -no-shell-escape or the pandoc equivalent in programmatic LaTeX compilation calls.	.jules/sentinel.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.