fix: Split backend pre_conversion/analyzer.py (26K) + batch/queue_manager.py (22K) — post-#1769 split regrowth - #1904
Open
webbrain-one wants to merge 1 commit into
Open
Conversation
Addresses post-split regrowth from anchapin#1769 by extracting logic into dedicated files: - pre_conversion/rules.py and file_checks.py for scan rules and file-type validation - batch/queue_backend.py for Redis/Celery adapter, leaving queue_manager.py as orchestration only Fixes anchapin#1871
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @webbrain-one, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Reviewer's GuideThis PR continues the post-#1769 backend split by extracting Redis/Celery queue integration and pre-conversion scanning logic into focused service modules, improving separation of concerns and making batch/queue_manager.py and pre_conversion/analyzer.py thinner orchestration layers. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce coupling and prevent “regrowth” of large backend modules by extracting pre-conversion scan rules/file checks and batch queue broker adapters into dedicated service modules.
Changes:
- Added
pre_conversion/rules.pyto centralize static scan rule definitions. - Added
pre_conversion/file_checks.pyto host per-file-type validation helpers. - Added
batch/queue_backend.pyto encapsulate Redis/Celery broker interactions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| backend/src/services/pre_conversion/rules.py | Introduces a rules data model and initial regex-based scan rules. |
| backend/src/services/pre_conversion/file_checks.py | Adds helper functions for validating manifests/resource packs and scanning asset directories. |
| backend/src/services/batch/queue_backend.py | Adds Redis job-state/progress publishing and Celery submit/poll wrappers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+6
| """Scan-rule definitions extracted from pre_conversion/analyzer.py (Issue #1871). | ||
|
|
||
| This module centralizes static analysis rules, regex patterns, and AST-based | ||
| heuristics used to detect compatibility issues, unsupported APIs, and risky | ||
| code patterns during the pre-conversion scan phase. | ||
| """ |
Comment on lines
+15
to
+20
| class RuleSeverity(Enum): | ||
| """Severity levels for pre-conversion scan rules.""" | ||
| ERROR = auto() | ||
| WARNING = auto() | ||
| INFO = auto() | ||
|
|
| id="PRE-001", | ||
| name="Forge API Usage", | ||
| severity=RuleSeverity.ERROR, | ||
| pattern=re.compile(r"import\s+net\.minecraftforge", re.IGNORECASE), |
Comment on lines
+34
to
+52
| """Validate pack.mcjson for Bedrock compatibility prerequisites. | ||
|
|
||
| Returns a dictionary with compatibility flags and missing dependencies. | ||
| """ | ||
| result: dict[str, Any] = {"compatible": True, "missing": []} | ||
| pack_file = pack_path / "pack.mcjson" | ||
| if not pack_file.exists(): | ||
| return result | ||
|
|
||
| try: | ||
| with open(pack_file, encoding="utf-8") as f: | ||
| data = json.load(f) | ||
| if data.get("pack_format", 0) < 2: | ||
| result["compatible"] = False | ||
| result["missing"].append("pack_format >= 2") | ||
| except json.JSONDecodeError as e: | ||
| result["compatible"] = False | ||
| result["missing"].append(f"Invalid JSON in pack.mcjson: {e}") | ||
| return result |
Comment on lines
+26
to
+27
| if "modLoader" in content or "loaderVersion" in content: | ||
| issues.append("Legacy FML manifest detected; may require manual mapping.") |
Comment on lines
+56
to
+59
| """Walk asset directory and flag files with unsupported extensions or sizes. | ||
|
|
||
| Returns a list of problematic file paths. | ||
| """ |
Comment on lines
+51
to
+54
| def publish_progress(self, job_id: str, progress: float, message: str = "") -> None: | ||
| """Emit progress update via Redis channel.""" | ||
| payload = json.dumps({"job_id": job_id, "progress": progress, "message": message}) | ||
| self._redis.publish(f"progress:{job_id}", payload) |
Comment on lines
+72
to
+78
| def poll_result(self, task_id: str) -> dict[str, Any] | None: | ||
| """Check task completion status without blocking.""" | ||
| from celery.result import AsyncResult # noqa: PLC0415 | ||
| async_result = AsyncResult(task_id, app=self._app) | ||
| if async_result.ready(): | ||
| return {"status": async_result.status, "result": async_result.get(timeout=0)} | ||
| return None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1871
Summary by Sourcery
Extract queue broker integration and pre-conversion analysis responsibilities into dedicated backend service modules to reduce coupling and prepare for further splitting of large files.
New Features: