Support light and dark terminals for Ion syntax highlighting#218
Merged
Conversation
jobarr-amzn
approved these changes
May 20, 2026
Comment on lines
+43
to
+49
| let light_mode = terminal_light::luma().is_ok_and(|luma| luma > 0.6); | ||
| let theme_name = if light_mode { | ||
| "Monokai Extended Light" | ||
| } else { | ||
| "Monokai Extended" | ||
| }; | ||
| let theme = assets.get_theme(theme_name).clone(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Follow-up to #201 to make it ready to be released.
--no-color.ion inspect. (Syntect highlighting is not compatible with theion inspectoutput. It takes ages to produce the output, and it's garbled.)with_syntax_highlighting()to make this less likely to get confused in the future..gitignorefileBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.