feat: harden evidence submissions and remove per-consumer infraction params#16
Draft
feat: harden evidence submissions and remove per-consumer infraction params#16
Conversation
Pantani
requested review from
giuliostramondo,
giunatale,
julienrbrt and
tbruyelle
…idation # Conflicts: # x/vaas/provider/types/keys.go # x/vaas/provider/types/keys_test.go
… already tombstoned - Enforce infraction header height == evidence height and header chain-id matches the consumer chain-id.
Pantani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5
Description
infraction_parametersfrom provider tx/query protos (tags reserved) and CLI JSON examples.SubmitConsumerMisbehaviour/SubmitConsumerDoubleVotingagainst nil inputs and invalid submitters (avoid panics).chain_idmatches the stored consumer chain-id, and the header height matches the evidence height.Breaking changes
infraction_parametersremoved fromMsgCreateConsumer,MsgUpdateConsumer,Chain, andQueryConsumerChainResponse.