feat(x/provider): withdraw funds from consumer pool address at each block#10
Open
feat(x/provider): withdraw funds from consumer pool address at each block#10
Conversation
Pantani
requested review from
giuliostramondo,
giunatale,
julienrbrt and
tbruyelle
…e-payment # Conflicts: # x/vaas/provider/types/params.go
tbruyelle
reviewed
Feb 6, 2026
tbruyelle
reviewed
Feb 6, 2026
tbruyelle
approved these changes
Feb 6, 2026
Contributor
tbruyelle
left a comment
tbruyelle
left a comment
There was a problem hiding this comment.
Some small comments but overall LGTM, thanks !
Pantani
commented
Feb 6, 2026
| ) | ||
|
|
||
| // TODO: Implement mechanism to inform the consumer chain to stop | ||
| // This could involve setting the phase to CONSUMER_PHASE_STOPPED |
Contributor
Author
There was a problem hiding this comment.
@tbruyelle wdyt implement the CONSUMER_PHASE_OVERDUE or only set as CONSUMER_PHASE_STOPPED?
Contributor
There was a problem hiding this comment.
It's a bit difficult to determine this now. We'll see when we'll implement how to stop the consumer chain.
Contributor
Author
There was a problem hiding this comment.
@tbruyelle I will handle the halt/stop system in another PR, ok?
…e-payment # Conflicts: # x/vaas/provider/types/provider.pb.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #9