Skip to content

Configuring versionIncrementer is cumbersome in Kotlin DSL #841

Description

@radoslaw-panuszewski

Expected behavior

scmVersion {
    versionIncrementer = PredefinedVersionCreator.INCREMENT_MINOR.versionIncrementer
}

Current behavior

scmVersion {
    versionIncrementer = VersionProperties.Incrementer { it.currentVersion.incrementMinorVersion() }
}

Context

There are 2 interfaces: PredefinedVersionIncrementer.VersionIncrementer and VersionProperties.Incrementer. The latter is exposed to DSL via VersionConfig.getVersionIncrementer() but PredefinedVersionIncrementer implements the former.

The similar config versionCreator has only one interface VersionProperties.Creator and PredefinedVersionCreator implements it. We should do it the same way for versionIncrementer.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions