This repository was archived by the owner on Jun 23, 2021. It is now read-only.
Re #1692 prevent query repeats and not fetch rows which are not required#1
Open
zainengineer wants to merge 1 commit into
Open
Re #1692 prevent query repeats and not fetch rows which are not required#1zainengineer wants to merge 1 commit into
zainengineer wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
This query deserves a LIMIT statement to reduce the scope and severity of catastrophically bad data. Something like LIMIT 1000 would provide a decent safeguard, if we can assume this should never return more than 1000 rows.
Author
There was a problem hiding this comment.
@parhamr next line ->where("$columnName != ''"); should limit the result.
If in any case it does not we need to investigate it further, as if config has hex value we need it in the category listing.
|
Hi, |
|
Great outcome in production:
(ignore the mistake at 13:55) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jonpday please review