[Aikido] Fix security issue in esbuild via minor version upgrade from 0.28.0 to 0.28.1#1708
Open
aikido-autofix[bot] wants to merge 2 commits into
Open
[Aikido] Fix security issue in esbuild via minor version upgrade from 0.28.0 to 0.28.1#1708aikido-autofix[bot] wants to merge 2 commits into
aikido-autofix[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade esbuild to fix remote code execution via unverified binary downloads in Deno and path traversal on Windows dev server.
✅ Code not affected by breaking changes.
✅ No breaking changes from esbuild 0.28.0 => 0.28.1 affect this codebase.
Analysis:
HTTP requests with backslash characters in paths: This codebase does not use esbuild's local development server. The
@aligent/cdk-esbuildpackage only usesbuildSync()for bundling Lambda functions during CDK synthesis (as seen inpackages/constructs/esbuild/esbuild.ts). The development server feature (.serve()) is not used anywhere in the codebase.Custom package registry integrity checks: No usage of custom NPM registries (
NPM_CONFIG_REGISTRY) or Deno API was found in the codebase. The project uses standard npm/yarn package management without custom registry configurations.The esbuild package is used exclusively for build-time bundling of Lambda@Edge handlers and Lambda functions, not for running a development server or using the Deno API. Therefore, neither breaking change impacts this codebase.
All breaking changes by upgrading esbuild from version 0.28.0 to 0.28.1 (CHANGELOG)
\backslash characters are no longer allowed in the local development serverNPM_CONFIG_REGISTRY) must now match the expected content due to integrity checks in the Deno API✅ 2 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
servedirroot directory.🤖 Remediation details
Fix esbuild security vulnerabilities (GHSA-gv7w-rqvm-qjhr, GHSA-g7r4-m6w7-qqqr)
Short summary
This PR remediates two security advisories (one HIGH, one LOW severity) affecting
esbuild. The vulnerable package appears as a transitive dependency consumed by two workspace members —packages/constructs/esbuildandpackages/cdk-aspects— both of which declare"esbuild": "^0.28.0"in their respectivepackage.jsonmanifests. No manifest files required editing; onlyyarn.lockwas updated to resolveesbuildto the patched version.esbuild
Both workspace packages (
@aligent/cdk-esbuildatpackages/constructs/esbuildand@aligent/cdk-aspectsatpackages/cdk-aspects) already declared"esbuild": "^0.28.0", a range that permits0.28.1. The lockfile had simply resolved to0.28.0at install time and was not yet refreshed to the patched release. Runningyarn up -R esbuild --mode=update-lockfilerefreshed the single shared lockfile entry — and all accompanying@esbuild/*platform-specific optional packages — from0.28.0to0.28.1without any manifest changes, resolving both advisories.Version changes
esbuild0.28.00.28.1@esbuild/aix-ppc640.28.00.28.1@esbuild/android-arm0.28.00.28.1@esbuild/android-arm640.28.00.28.1@esbuild/android-x640.28.00.28.1@esbuild/darwin-arm640.28.00.28.1@esbuild/darwin-x640.28.00.28.1@esbuild/freebsd-arm640.28.00.28.1@esbuild/freebsd-x640.28.00.28.1@esbuild/linux-arm0.28.00.28.1@esbuild/linux-arm640.28.00.28.1@esbuild/linux-ia320.28.00.28.1@esbuild/linux-loong640.28.00.28.1@esbuild/linux-mips64el0.28.00.28.1@esbuild/linux-ppc640.28.00.28.1@esbuild/linux-riscv640.28.00.28.1@esbuild/linux-s390x0.28.00.28.1@esbuild/linux-x640.28.00.28.1@esbuild/netbsd-arm640.28.00.28.1@esbuild/netbsd-x640.28.00.28.1@esbuild/openbsd-arm640.28.00.28.1@esbuild/openbsd-x640.28.00.28.1@esbuild/sunos-x640.28.00.28.1@esbuild/win32-arm640.28.00.28.1@esbuild/win32-ia320.28.00.28.1@esbuild/win32-x640.28.00.28.1