Repository navigation
examples/protobuf: add explicit lexer with comment support - #486
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Owner
|
Thanks for the PR, but that issue should have been closed - the current example is working as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #446.
Problem and Root Cause
The protobuf example in _examples/protobuf did not define a custom lexer and instead relied on Participle default lexer (TextScannerLexer). Go underlying text/scanner.Scanner defaults to GoTokens, which sets scanner.SkipComments. This discards all // and /* ... */ comments at the scanner level before tokens reach Participle. Consequently, attempts to preserve, capture, or match comments fail because no comment tokens exist in the token stream.
Solution
@Commentto Entry so entry-level comments can be preserved in the AST when desired.Verification