Skip to content

Auth improvements#46

Merged
lohnim merged 5 commits intomainfrom
chris/auth-improvements
Apr 1, 2026
Merged

Auth improvements#46
lohnim merged 5 commits intomainfrom
chris/auth-improvements

Conversation

@lohnim
Copy link
Copy Markdown
Collaborator

@lohnim lohnim commented Apr 1, 2026

  1. Browser auth only (you can't do all the stuff with just access key, api key or siws - better to just get rid of it otherwise the flow will be very complicated)
image
  1. Prompt app selection if API key is missing
image
  1. Type to search app
image
  1. Background for auth success/failed page
image 5. Fix config list

@lohnim lohnim requested a review from a team as a code owner April 1, 2026 01:48

if (!yes && !isJSONMode() && isInteractiveAllowed(program)) {
const proceed = await promptConfirm({
message: "Press Enter to open browser and log in",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it Enter or y/n to open the browser? Looks like the image attaches y/n prompt

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to y if enter is pressed. That's the convention for [Y/n] where the capital is the default for no input!

@lohnim lohnim merged commit 3cb4de9 into main Apr 1, 2026
7 checks passed
@lohnim lohnim deleted the chris/auth-improvements branch April 1, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants