feat: encrypt config.json at rest with AES-256-GCM#41
Closed
lohnim wants to merge 2 commits intochris/authfrom
Closed
feat: encrypt config.json at rest with AES-256-GCM#41lohnim wants to merge 2 commits intochris/authfrom
lohnim wants to merge 2 commits intochris/authfrom
Conversation
Derive a machine-bound key via PBKDF2 from hostname + uid + username and encrypt the config file with AES-256-GCM. Existing plaintext configs auto-migrate on first load. Also fixes test isolation for XDG_CONFIG_HOME/ALCHEMY_CONFIG env vars. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Instead of silently returning empty config, print a message explaining the likely cause (different machine / hostname change), back up the unreadable file to config.json.bak, and suggest reconfiguring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XDG_CONFIG_HOME/ALCHEMY_CONFIGenv varsDetails
The encrypted format uses an
ALCH_ENCmagic prefix + version byte + random salt/IV, making it distinguishable from plaintext JSON. File permissions remain0600. Corrupted or unreadable files gracefully fall back to empty config with a warning.Test plan
🤖 Generated with Claude Code