Callback method when the translation for the key is not found.#469
Open
stha-ums wants to merge 7 commits into
Open
Callback method when the translation for the key is not found.#469stha-ums wants to merge 7 commits into
stha-ums wants to merge 7 commits into
Conversation
stha-ums
marked this pull request as draft
April 5, 2022 15:37
stha-ums
marked this pull request as ready for review
April 5, 2022 15:45
Collaborator
|
LGTM, could you write test code for |
Author
|
@kyle-seongwoo-jun sure. I will write as soon as I am available. |
aissat
force-pushed
the
develop
branch
2 times, most recently
from
May 13, 2022 15:17
66adb74 to
8048ff5
Compare
|
omg, I need this! |
Author
|
@kyle-seongwoo-jun I have added a test, could you review it? |
use debugprint instead of print to fix linting
bw-flagship
requested changes
Jun 17, 2023
| ], | ||
| path: 'resources/langs', | ||
| onLocaleKeyNotFound: (key, locale) { | ||
| print('Locale key not found $key ${locale.languageCode}'); |
Collaborator
There was a problem hiding this comment.
Please use EasyLocalization.logger instead of print
| this.assetLoader = const RootBundleAssetLoader(), | ||
| this.saveLocale = true, | ||
| this.errorWidget, | ||
| this.onLocaleKeyNotFound}) |
Collaborator
There was a problem hiding this comment.
trailing comma is missing
| })); | ||
| }); | ||
|
|
||
| test('should call onLocaleKeyNotFound', () { |
Collaborator
There was a problem hiding this comment.
lets add another test to verify that the method is NOT called when the translation exists
Collaborator
|
@stha-ums Sorry that you waited so long here. Are you still willing to contribute this feature? (I submitted a review). |
Author
|
@bw-flagship , thank you for taking the time to review, I will address these as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes us able to perform extra tasks if there is no translation available.
For example, The project I am working on uses localization from the backend. And need to tell the backend if any translation is missing. So this method allows me to achieve that.