Repository navigation
vt/kitty: bind drops of the Kitty drag and drop protocol - #13
Merged
Merged
Conversation
Upstream main through 83edd491e, plus ghostty-org/ghostty#14508 (ctrl+alt+shift+backspace in legacy mode) and #14509 (clear a wide char cut by a non-reflow narrowing), taken ahead of upstream. Co-Authored-By: Claude Code
Pins aislopware/ghostty 497a31663, which merges ghostty-org/ghostty#14511 (kitty dnd: finish up the core implementation) ahead of upstream. Binds the drop side: the kitty_dnd effect (Terminal::on_kitty_dnd), the drop state reads, drop_move, drop_leave, drop and the data request answers. Drags the program offers are not bound yet. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #12 (merge that first). Pins aislopware/ghostty 497a31663, which merges ghostty-org/ghostty#14511 (kitty dnd: finish up the core implementation, still open upstream) on top of 3e0c37789.
Binds the drop side of OSC 72, in a new
kitty::dndmodule: the kitty_dnd effect (Terminal::on_kitty_dnd), the drop state reads (registered, registered MIME types, accepted operation and MIME types, the request to serve),dnd_drop_move,dnd_drop_leave,dnd_drop, and the request answers (dnd_drop_respond_data,_end,_error). Drags offered by the program, the other direction, are not bound yet; their events are passed through asEvent::Offersand the like.Tests (
kitty::dnd::tests): nothing reaches a program that did not register; a full drop (registration, move, acceptance, drop, a data request answered with data, a second failed with EIO, conclusion, unregistration); a drag leaving. The 99 lib tests pass.Co-Authored-By: Claude Code