Repository navigation
Fix Remaining permission and group typing - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 2 typing errors:
fetchItemNameGroupsandfetchLocationNameGroupsdo not currently strip the outer object returned by the data storage operation, meaning the groups need an extra step to extract them like so:however only the inner record was typed, not the outer record producing type errors.
The long term fix would be to automatically strip the outer object to return the groups themselves, that would be a breaking change.
The other typing error fixes was for remaining permission. Previously they used the
Omithelper which omits properties, not values. The proper helper to use is theExcludehelper, which excludes vales from a different type.Now the type properly shows the valid values, instead of an odd type that produces errors.
Before:
After:
Tested these and was able to compile code without
ts-ignoreorts-expect-errorcomments for code does work at runtime.