Skip to content

Add SamudrACE CM4 piControl baseline configs#898

Merged
jpdunc23 merged 12 commits intomainfrom
config/coupled-cm4-piControl
Apr 8, 2026
Merged

Add SamudrACE CM4 piControl baseline configs#898
jpdunc23 merged 12 commits intomainfrom
config/coupled-cm4-piControl

Conversation

@jpdunc23
Copy link
Copy Markdown
Member

@jpdunc23 jpdunc23 commented Mar 4, 2026

Adds scripts and configs for baseline training of SamudrACE on the CM4 piControl dataset.

@oliverwm1
Copy link
Copy Markdown
Collaborator

Took a brief look—I think it generally looks good and appreciate the readme. A couple thoughts:

  • how do these scripts related to the existing cm4-ocean, cm4-atmosphere and cm4/coupled-inference-no-target directories in ace/configs/baselines? It is important to avoid duplication and have a single source of truth for configs, so I suspect that maybe all of those directories should be deleted in favor of this new one?
  • why the nested coupled folder? Could just have configs/baselines/cm4-piControl right?

@elynnwu elynnwu marked this pull request as ready for review April 8, 2026 22:08
@elynnwu
Copy link
Copy Markdown
Contributor

elynnwu commented Apr 8, 2026

  • how do these scripts related to the existing cm4-ocean, cm4-atmosphere and cm4/coupled-inference-no-target directories in ace/configs/baselines? It is important to avoid duplication and have a single source of truth for configs, so I suspect that maybe all of those directories should be deleted in favor of this new one?

Deleted cm4-ocean, cm4-atmosphere, cm4/coupled-inference-no-target

  • why the nested coupled folder? Could just have configs/baselines/cm4-piControl right?

Updated to configs/baselines/cm4-piControl

Copy link
Copy Markdown
Collaborator

@oliverwm1 oliverwm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpdunc23 jpdunc23 enabled auto-merge (squash) April 8, 2026 23:03
@jpdunc23 jpdunc23 merged commit 65b4836 into main Apr 8, 2026
7 checks passed
@jpdunc23 jpdunc23 deleted the config/coupled-cm4-piControl branch April 8, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants