Conversation
Every failed /email/poll logged the whole axios error (request, socket, agent) every 10 seconds. On one install that was 83k entries in a week: 41k 'HTTP 410 retired, pro_required' and 41k 'HTTP 401' before sign-in. - Failures log one short line (status plus the server's reason), and only when the reason changes; a later success logs one recovery line. - 410 means the mail service will not serve this client, so polling stops until the next start instead of retrying forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EmailReceiverpolls/email/pollevery 10 seconds and logs the entire axios error on every failure: request, socket and agent included. On one desktop install that was 83,334 log entries in a week, which pushed the daily log to 366 MB:HTTP 410 { error: 'retired', reason: 'pro_required', service: 'mail.agnt.gg' }HTTP 401 { error: 'Authentication required', reason: 'missing' }(before sign-in)Change
Please check
pro_requiredrollout? If a user upgrades while the app is running, email triggers resume only after a restart. An alternative is a long back-off (for example hourly) instead of stopping.Verification
EmailReceiver.poll.test.js: 3 tests (410 stops with one short line, repeated 401 logs once, reason change and recovery). All 3 failed before the change and pass after.main:sessionTokenCache.test.js(date-expired fixture, fixed in fix(storage): prevent test boot of real user database #145) andbrowserActDriver.live.test.js(needs a real browser).